Skip to content

Commit

Permalink
Merge pull request #501 from sul-dlss/webdriver
Browse files Browse the repository at this point in the history
Remove pin of chromedriver and remove webdrivers gem
  • Loading branch information
jcoyne authored Aug 2, 2023
2 parents 3a6ea09 + 254057e commit f8c2f44
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
1 change: 0 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ end
group :test do
gem 'capybara', ">= 2.15"
gem 'selenium-webdriver', '!= 3.13.0'
gem 'webdrivers'
gem 'simplecov', require: false
gem 'database_cleaner'
gem 'rails-controller-testing'
Expand Down
7 changes: 1 addition & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ GEM
ruby-progressbar (1.13.0)
ruby2_keywords (0.0.5)
rubyzip (2.3.2)
selenium-webdriver (4.10.0)
selenium-webdriver (4.11.0)
rexml (~> 3.2, >= 3.2.5)
rubyzip (>= 1.2.2, < 3.0)
websocket (~> 1.0)
Expand Down Expand Up @@ -365,10 +365,6 @@ GEM
activemodel (>= 6.0.0)
bindex (>= 0.4.0)
railties (>= 6.0.0)
webdrivers (5.2.0)
nokogiri (~> 1.6)
rubyzip (>= 1.3.0)
selenium-webdriver (~> 4.0)
websocket (1.2.9)
websocket-driver (0.7.6)
websocket-extensions (>= 0.1.0)
Expand Down Expand Up @@ -425,7 +421,6 @@ DEPENDENCIES
turbo-rails
tzinfo-data
web-console (>= 3.3.0)
webdrivers
whenever (~> 1.0)

BUNDLED WITH
Expand Down
4 changes: 0 additions & 4 deletions spec/rails_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,6 @@
require 'capybara/rails'
require 'selenium-webdriver'

# We may be able to remove this line when selenium 4.11 is released
# See https://github.com/titusfortner/webdrivers/issues/247#issuecomment-1648154088
Webdrivers::Chromedriver.required_version = '114.0.5735.90'

Capybara.javascript_driver = :selenium_chrome_headless

RSpec.configure do |config|
Expand Down

0 comments on commit f8c2f44

Please sign in to comment.