Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing duplicate instructors across meetings for same section #482

Merged
merged 1 commit into from
May 22, 2023

Conversation

hudajkhan
Copy link
Contributor

@hudajkhan hudajkhan commented May 22, 2023

If the XML for an individual course has the following hierarchy (the example omits other attributes and elements not related to this pull request):

"<CourseClass ...> <class> <section>
<meeting number="1"><instructor> <person sunet="123"></person></instructor></meeting>
<meeting number="2"><instructor> <person sunet="123"></person></instructor></meeting>
</section></class></CourseClass>"

We want the information returned to not duplicate instructor names. The xpath pattern that was being used to match against instructor names for the section returned the full list, which in this case would mean duplicating the instructor with sunet id "123". This code update only keeps a unique set of sunet ids and related names for each section, and returns them in the information for the section.

@hudajkhan
Copy link
Contributor Author

Relates to #410

@cbeer cbeer merged commit 099895c into master May 22, 2023
@cbeer cbeer deleted the updateInstructorLogic branch May 22, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants