Prune away unnecessary sass

[jcoyne]

No description provided.

[taylor-steve]

Locally it looks like we've lost the navbar logo:

[taylor-steve]

The only other thing I see is it seems we've lost the black text here on the active facet header:

https://sul-arclight-demo.stanford.edu/collections

[corylown]

Many of the issues below seem specific for Firefox 115.11.0esr (which is what gets installed by Stanford's Self Service app). I will review again with Firefox 126.0.1

General

Hamburger menu

icon should be rgb(255, 255, 255)

main:

prune-sass

Header links

link color should be rgb(255, 255, 255)
active link color should be rgb(255, 255, 255)
hover state should be underlined
should be separated by a dot

main:

prune-sass:

Masthead h1

--al-masthead-title-size should be 36px at larger screen widths not 40px

main:

prune-sass:

--al-masthead-title-size should be 24px at smaller screen widths not 32px

main:

prune-sass:

hover state should be underlined

main:

prune-sass:

Landing Page

Search button background

should be rgb(255, 255, 255)

main:

prune-sass:

Grey masthead alignment

Should align with yellow and green backgrounds above

main:

prune-sass:

Cards

Card buttons should both be the same width and span almost the entire width of the containing card-body div

main:

prune-sass:

Card images should sit above the card div
Card h3 font weight should be 700

main:

prune-sass:

h1 & h2 text (Find Archival Materials, About this site)

Should be font-family "Source Serif 4", serif
font weight should be 700
font size should be 36px

main:

prune-sass:

Masthead image caption links

Caption links should be white
Caption links hover state should be underlined
Caption link should be font-weight 600

main:

prune-sass:

Browse links

Should be horizontal and separated by a dot the same color as the link text

main:

prune-sass:

Repositories Page

Cards

Card buttons should both be the same width and span almost the entire width of the containing card-body div

main:

prune-sass:

Card images should sit above the card div

main:

prune-sass:

Bottom of card image and card h2 should align with the adjacent card
Card h3 font weight should be 700

main:

prune-sass:

Cards and footer should not overlap

main:

prune-sass:

Results Page

Icons

Bookmark icon color should be rgb(1, 66, 64)
Result type icon color should be rgb(1, 66, 64)

main:

prune-sass:

Digital content

Design reference: #602

font weight should be 700
should have solid left border, color rgb(1, 66, 64), 8px wide

main:

prune-sass:

Pagination

Previous and Next buttons should have background color rgb(1, 66, 64)

main:

prune-sass:

Applied facets

applied-filter Remove facet button hover state background should be rgb(1, 66, 64)

main:

prune-sass:

selected facet-level-header background should be rgb(212, 209, 209)

main:

prune-sass:

Search widget

selection color in dropdown should be rgb(1, 66, 64)

main:

prune-sass:

hover state should be underlined

main:

prune-sass:

Result links

hover state should be underlined (this looks like a general problem)

main:

prune-sass:

Collection/Component Page

Collection panel

Padding needs attention
Collection overview link list should have disc list style in the same color as the links
More info button should not have an icon and the background should be white
background color should be rgb(235, 245, 241)

main:

prune-sass:

Browse hierarchy panel

Expand button should have background color rgb(255, 255, 255)
Expand button link hover state should be underlined and background rgb(1, 66, 64)

main:

prune-sass:

Digital content

Design reference: #602

font weight should be 700
should have solid left border, color rgb(1, 66, 64), 8px wide
height should be 32px

main:

prune-sass:

Search controls

Search label should not look like a button. The background should match navbar-search rgb(46, 45, 41)
Search label font weight should be 700
There should be even spacing between each segment of the search selects/inputs

main:

prune-sass:

[jcoyne]

@corylown aside from one or two of those, I don't see anything like that. Maybe do bin/rails assets:clobber first.

[corylown]

The following are still issues on Firefox 126.0.1:

• hamburger menu icon color
• document type icon color
• bookmark icon color on index page (it's fine on the show page)
• remove facet hover state background color

[jcoyne]

@corylown I believe those issues are resolved.

[corylown]

@jcoyne now that Stanford is on Firefox 128.4.0esr I think this could be rebased and I'd review again.

[corylown]

Looks great. See inline comment about the palette import.

[corylown]

I get a 404 for this import when it's wrapped in the url() helper.

Suggested change

	@import url("palette");
	@import "palette";