Remove strtolower transform from RedirectRoute::setTarget (#85)

sulu · Sep 8, 2022 · 964aae9 · 964aae9
1 parent bbd4d90
commit 964aae9
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 14 deletions.
diff --git a/Entity/RedirectRoute.php b/Entity/RedirectRoute.php
@@ -155,7 +155,7 @@ public function getTarget()
      */
     public function setTarget($target)
     {
-        $this->target = mb_strtolower($target);
+        $this->target = $target;
 
         return $this;
     }

diff --git a/Import/Writer/DuplicatedSourceException.php b/Import/Writer/DuplicatedSourceException.php
@@ -30,9 +30,7 @@ public function __construct(RedirectRouteInterface $entity)
         $this->entity = $entity;
     }
 
-    /**
-     * {@inheritdoc}
-     */
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return [

diff --git a/Import/Writer/TargetIsEmptyException.php b/Import/Writer/TargetIsEmptyException.php
@@ -30,9 +30,7 @@ public function __construct(RedirectRouteInterface $entity)
         $this->entity = $entity;
     }
 
-    /**
-     * {@inheritdoc}
-     */
+    #[\ReturnTypeWillChange]
     public function jsonSerialize()
     {
         return [

diff --git a/Tests/Functional/Routing/RedirectRouteProviderTest.php b/Tests/Functional/Routing/RedirectRouteProviderTest.php
@@ -37,7 +37,7 @@ public function testRoute(
         string $requestUrl,
         string $source,
         int $statusCode,
-        ?string $target = null,
+        string $target = '',
         ?string $sourceHost = null
     ) {
         // setup models

diff --git a/Tests/Unit/Entity/RedirectRouteTest.php b/Tests/Unit/Entity/RedirectRouteTest.php
@@ -78,6 +78,6 @@ public function testTarget()
         $this->assertSame('target-url', $route->getTarget());
 
         $this->assertSame($route, $route->setTarget('UPPERCASE-TARGET'));
-        $this->assertSame('uppercase-target', $route->getTarget());
+        $this->assertSame('UPPERCASE-TARGET', $route->getTarget());
     }
 }
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -315,11 +315,6 @@ parameters:
 			count: 1
 			path: Tests/Functional/Routing/RedirectRouteProviderTest.php
 
-		-
-			message: "#^Parameter \\#1 \\$target of method Sulu\\\\Bundle\\\\RedirectBundle\\\\Entity\\\\RedirectRoute\\:\\:setTarget\\(\\) expects string, string\\|null given\\.$#"
-			count: 1
-			path: Tests/Functional/Routing/RedirectRouteProviderTest.php
-
 		-
 			message: "#^Call to an undefined method Sulu\\\\Bundle\\\\RedirectBundle\\\\Model\\\\RedirectRouteInterface\\:\\:reveal\\(\\)\\.$#"
 			count: 4