Allow to configure hostname for redirect #53
Conversation
There was a problem hiding this comment.
Hey,
I am sorry for not reacting on this sooner. I did not find the time to have a deeper look on this until now. I hope the delay did not cause any big inconvenience for you.
We have planned to not add any new features to the Sulu 1 branches of our projects after the release of Sulu 2. But I will talk to the team after the comments are resolved to make an exception here because the code looks well built and we have not tagged an official Sulu 2 version of this bundle.
Also, we found some time to move the tests of the bundle to Github actions. Would be nice if you could rebase your branch onto the 0.x branch to run the pipelines.
Thanks a lot for your effort and sorry again for the delay!
|
Hi, No problem at all; we've forked this repo. But it would be neat if the change could make it into the official repo, so we have a bit less maintenance overhead in the future. On the other hand it's not a big problem if you would decide not to merge it after all. In any case, thanks a lot for taking the time to do the PR review! Your comments have been processed and the branch has been rebased onto Please let me know if you spot any other improvements. Thanks again! |
niklasnatter
changed the title
|
@choonge The team decided to merge this as we wanted to include this feature in the first Sulu 2 version of the bundle anyway. Sorry again for the delay - thanks a lot for working on this 🙂 |
|
@nnatter Great news, thank you! When ready, could you please create a new tag? Thanks again! |
What's in this PR?
Implementation of #35
Why?
Allows for redirects by per hostname. Hostname is optional; redirects will fall back to the one without defined sourceHost if no specific redirect exists.
Example Usage