Fix GoneDocumentSubscriber by passing sourceHost to RedirectRouteManager #72
Conversation
niklasnatter
force-pushed
the
bugfix/gone-source-host
branch
from
078945f to
d5b52d4
Compare
| $this->redirectRouteManager->saveByData(['source' => $url, 'statusCode' => 410, 'enabled' => true, 'target' => '']); | ||
| $this->redirectRouteManager->saveByData([ | ||
| 'source' => $url, | ||
| 'sourceHost' => null, |
There was a problem hiding this comment.
Here we need to set the webspace domain for pages aslong as there is no {host} replacer set. Else if I have a page /test in 2 webspaces and remove both it should redirect to the correct domain.
There was a problem hiding this comment.
How could I get the correct domain? I think there could be multiple configured domains for a single webspace, right?
There was a problem hiding this comment.
But not sure if we need to be strict here. I think the worst thing that can happen is that we return a 410 in a webspace that never had a page on that URL, right?
There was a problem hiding this comment.
2 possibilities:
A. we create a redirect for every configured domain for the current environment
B. create a redirect only for the main / first domain found in the webspace config for the current environment
For me both is okay.
There was a problem hiding this comment.
we already generate all urls here
There was a problem hiding this comment.
But not sure if we need to be strict here. I think the worst thing that can happen is that we return a 410 in a webspace that never had a page on that URL, right?
🤔 thats correct maybe we stay with this solution currently then.
There was a problem hiding this comment.
Thanks! But how can I find out if there was a {host} replacer in the URL? 🙈
There was a problem hiding this comment.
Think thats not longer possible as we don't have a method for it 🤔
Why?
See #71