Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong namespace of RedirectRouteTest #77

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Fix wrong namespace of RedirectRouteTest #77

merged 3 commits into from
Jun 12, 2021

Conversation

optior
Copy link
Contributor

@optior optior commented Jun 12, 2021

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

What's in this PR?

This PR fixes wrong namespace of RedirectRouteTest.

Why?

When running dump-autoload --classmap-authoritative there's a warning:

Generating optimized autoload files (authoritative)
Class Sulu\Bundle\RedirectBundle\Tests\Unit\Import\Converter\RedirectRouteTest located in ./vendor/sulu/redirect-bundle/Tests/Unit/Entity/RedirectRouteTest.php does not comply with psr-4 autoloading standard. Skipping.
composer/package-versions-deprecated: Generating version class...
composer/package-versions-deprecated: ...done generating version class
Generated optimized autoload files (authoritative) containing 8401 classes

@alexander-schranz
Copy link
Member

alexander-schranz commented Jun 12, 2021

Thank you for fixing this. Seems like we also did forget the .gitattributes file in this project, do you want to create that also: https://github.com/sulu/SuluArticleBundle/blob/2.x/.gitattributes

@alexander-schranz alexander-schranz enabled auto-merge (squash) June 12, 2021 18:23
@alexander-schranz alexander-schranz merged commit 1a38a26 into sulu:2.x Jun 12, 2021
@alexander-schranz
Copy link
Member

@optior Thank you!

@optior optior deleted the optior-patch-1 branch June 13, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants