Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect import for symfony 6.x #86

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

luca-rath
Copy link
Contributor

@luca-rath luca-rath commented Oct 19, 2022

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets fixes #issuenum
Related issues/PRs #issuenum
License MIT

What's in this PR?

Fix redirect import for symfony 6.x

@@ -1,5 +1,5 @@
sulu_redirect.import:
path: /import
defaults: { _controller: sulu_redirect.controller.import:postAction }
defaults: { _controller: sulu_redirect.controller.import::postAction }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexander-schranz is it possible, that this worked until symfony 5.4, but not anymore in 6.0?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I even tought it was dropped in 4.4 but looks liek the keept it until 5.4

@luca-rath luca-rath force-pushed the bugfix/redirect-import branch from b4f877d to e4115d7 Compare October 19, 2022 15:31
@luca-rath luca-rath changed the title Fix redirect import and allow to import sourceHost Fix redirect import for symfony 6.x Oct 19, 2022
@luca-rath luca-rath force-pushed the bugfix/redirect-import branch from e4115d7 to 33d7220 Compare October 19, 2022 15:39
@alexander-schranz alexander-schranz merged commit ea6267e into sulu:2.1 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants