Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify supported npm versions in package.json and enable engine-strict to check npm version on install #102

Merged
merged 2 commits into from
Mar 31, 2021
Merged

Specify supported npm versions in package.json and enable engine-strict to check npm version on install #102

merged 2 commits into from
Mar 31, 2021

Conversation

niklasnatter
Copy link
Contributor

@niklasnatter niklasnatter commented Mar 31, 2021 •
edited
Loading

With this changes, the following error message is displayed when running npm install using npm 7:

▶ npm install
npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: undefined
npm ERR! notsup Not compatible with your version of node/npm: undefined
npm ERR! notsup Required: {"npm":"<7"}
npm ERR! notsup Actual:   {"npm":"7.7.6","node":"v12.17.0"}

@niklasnatter niklasnatter changed the base branch from 2.x to 2.1 March 31, 2021 12:38
@niklasnatter niklasnatter mentioned this pull request Mar 31, 2021
Merged
niklasnatter
niklasnatter commented Mar 31, 2021
View reviewed changes
.github/workflows/test-application.yaml
@@ -20,7 +20,7 @@ jobs:
matrix:
include:
- php-version: '7.2'
node-version: '10'
node-version: '12'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the @ckeditor/ckeditor5-core is not compatible with Node 10 🙈
https://github.com/sulu/skeleton/pull/102/checks?check_run_id=2236924856

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes did also run into this issue when I had the global engine_strict set on my development machine

alexander-schranz
alexander-schranz reviewed Mar 31, 2021
View reviewed changes
assets/admin/.npmrc
@@ -0,0 +1,3 @@
# the javascript setup in this folder is not compatible with npm 7: https://github.com/sulu/skeleton/issues/88
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add this file to the sulu admin update command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see sulu/sulu#5910 🙂

@alexander-schranz alexander-schranz merged commit 91b4024 into sulu:2.1 Mar 31, 2021
@niklasnatter
Copy link
Contributor Author

niklasnatter commented Apr 1, 2021 •
edited
Loading

For completion; this is related to #88

@niklasnatter niklasnatter mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexander-schranz alexander-schranz alexander-schranz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niklasnatter @alexander-schranz