-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre and postinstall script to fix custom build with ckeditor and custom builds on windows #96
Add pre and postinstall script to fix custom build with ckeditor and custom builds on windows #96
Conversation
125a82d
to
ff6d9f1
Compare
72bc866
to
e8274d6
Compare
993fd35
to
3e69159
Compare
Co-authored-by: nnatter <niklas.natter@gmail.com>
…anz/skeleton into feature/link-dependencies
@@ -35,7 +35,7 @@ | |||
"friendsofsymfony/http-cache-bundle": "^2.8", | |||
"handcraftedinthealps/zendsearch": "^2.0", | |||
"jackalope/jackalope-doctrine-dbal": "^1.3", | |||
"sulu/sulu": "~2.1.9", | |||
"sulu/sulu": "~2.1.9 || 2.1.*@dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how should we handle this? i guess we need to remember to reset this before releasing the next version? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
on release this always should be set to the correct version: ~2.1.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good - hope we remember that 🙂
- php-version: '7.4' | ||
mysql-version: '8.0' | ||
phpcr-transport: 'jackrabbit' | ||
dependency-versions: 'highest' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if we will test anything else here 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IDK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
highest is I think always the default for composer but maybe it has an impact if a lock is commitet or not to this github action. but for our case I think it doesn't matter and would keep as it is
Co-authored-by: nnatter <niklas.natter@gmail.com>
aa6be5c
to
e4665ab
Compare
Co-authored-by: nnatter <niklas.natter@gmail.com>
What's in this PR?
Add symlink for dependencies to workaround a behaviour npm does when thinking a dependencies is not a child of the current directory.
Why?
Npm can not work well when a depenencies is not a children.
Sideffects (resolved: see beneath)
Before:
After:
The new build is about
~3,1
and the old one was just~2,6M
. Strange is that there are less duplicated dependencies as before: https://www.diffchecker.com/Ge6npC1O still the build is bigger. Here a diff of the sizes stats: https://www.diffchecker.com/jrRrou54. As analysed the ckeditor package size has a big difference now: https://www.diffchecker.com/PM8Fk5F0After adding .browserlistrc
Its about
~2.4mb
.