Add support for NPM 8, 9, 10 and PNPM 8, remove support for NPM 6 #7286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
enhancement/node-npm-upgrade
branch
2 times, most recently
from
ab30f62 to
9482e2b
Compare
alexander-schranz
force-pushed
the
enhancement/node-npm-upgrade
branch
from
20ed1aa to
ee0f002
Compare
alexander-schranz
force-pushed
the
enhancement/node-npm-upgrade
branch
2 times, most recently
from
03e75e5 to
4355890
Compare
UPGRADE.md
Outdated
Comment on lines
14
to
18
| ### Custom Admin Builds npm version changed | ||
|
|
||
| Sulu 2.6 now supports [npm 8, 9, 10](https://nodejs.org/en/download) and even | ||
| [pnpm 8](https://pnpm.io/) or [bun 1](https://bun.sh/) to be used for custom admin | ||
| builds. To support this new versions we were required to drop support for NPM 6. |
There was a problem hiding this comment.
@Prokyonn can you have a look at this :)
Prokyonn
reviewed
Mar 14, 2024
Co-authored-by: Prokyonn <daniel.mathis@sector8.eu>
alexander-schranz
force-pushed
the
enhancement/node-npm-upgrade
branch
from
0e5f0a1 to
79edf75
Compare
Prokyonn
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
See sulu/skeleton#235
Why?
Node 16 is going for end of life: https://nodejs.org/en/about/previous-releases
Example Usage
BC Breaks/Deprecations
No support for NPM 6 / symlinked local packages.
Disadvantages
No watch task over vendor package developments as install requires
install-links=truewhich ends not longer uses symlinks. Instead a tarball is created and install, but it installs correctly dependencies of local dependencies. Which does not work forfile:packages.