-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Content Bundle to monorepository #7674
Merged
alexander-schranz
merged 207 commits into
sulu:3.0
from
alexander-schranz:feature/content-merge-into-sulu
Nov 25, 2024
Merged
Add Content Bundle to monorepository #7674
alexander-schranz
merged 207 commits into
sulu:3.0
from
alexander-schranz:feature/content-merge-into-sulu
Nov 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add create-content method to repository
Add missing result exception
* added .idea folder to the .gitignore file * adjusted name in jmsserializer configuration * added seo-form xml * added seo model and interface * implemented seo-controller, find-seo-query and basic modify-seo-message * added form configuration in sulu-content-extension * added translations for seo-form * improved phpdoc in content-repository-interface and content-view-factory-interface * implemented seo query-handler and message-handler, implemented seo-repository, implemented seo-view and seo-view-factory, adjusted various files * automatically fixed coding style with phpcs * made seo-model properties nullable, implemented modify-seo-message-handler * removed handling of unlocalized seo-dimensions in message-handlers * renamed getAttributes-method to createAttributes in publish-content-message-handler to match naming in other handlers * added serializer configuration for seo-view class * return empty seo-view in the seo-controller when seo is not found to unbreak form in the frontend * implemented publish-seo-message and its handler, added orm configuration for seo-view model * made bool properties of seo model nullable * added phpunit and webmozart-assert plugin for phpstan * refactored contet-view-factory-test, added seo-view-factory-test * added modify-seo-message-test and publish-seo-message-test * added seo-test and find-seo-query-test * refactored find-content-query-handler-test, added find-seo-query-handler-test * refactored modify-content-message-handler-test, added modify-seo-message-handler * refactored publish-content-message-handler-test, added publish-seo-message-handler-test * fixed namespace in seo unit-test files * added abstract prefix for abstract controller classes, renamed getResourceKey method * added functional test setup, created basic content-controller test * automatically fixed coding style with php-cs * implemented abstract-content-controller-test * implemented abstract-seo-controller-test * added comment in get-action of abstract-seo-controller and abstract-content-controller * renamed publish-dimension method, added copy-attributes-from method in seo-interface and content-interface * renamed form-key of seo-form from seo to content_seo * added test cases for testCopyAttributesFrom mothod of content-interface and seo-interface * fixed service-id of structure-metadata-factory
* renamed content class to content-dimension * renamed seo class to seo-dimension * renamed dimension class to dimension-identifier * replaced createAttributes method in handlers with getDimensionIdentifier method, improved method names in traits
…#6) * adjusted method names in content-dimension-repository and seo-dimension-repository * added find-by-resource metod to content-dimension-repository and seo-dimension-repository * implemented remove-content-message and its respective handler * implemented remove-seo-message and its respective handler * renamed remov method to remove-dimension in content-dimension-repository and seo-dimension-repository * automatically fixed coding style with php-cs * implemented remove-content-message-test and remove-content-message-handler-test * implemented remove-seo-message-test and remove-seo-message-handler-test * removed product leftovers from test files
* use entity-manager instead of container in dimension-identifier-trait, added doctrine.repository_serice tag to service definitions * added service definition for remove-content-message-handler and remove-seo-message-handler
…on in doctrine config (sulu#9) * changed table-name prefix from cs_ to cn_ * refactored doctrine-models to use no attribute as primary key * added column attribute to all fields in doctrin configurations * adjusted column-name of key field to prevent sql errors, fixed content-dimension-repository and soe-dimension-repository * fixed content-dimension-trait and seo-dimension-trait
* added excerpt-dimension and excerpt-dimension-interface * added excerp-dimension-repository and excerpt-dimension-repository-interface * added doctrine configuration for excerpt-dimension * implemented excerpt-view and excerpt-view-interface * implemented excerpt-view-factory and excerpt-view-factory-interface * added basic doctrine config for excerpt-view model * added excerpt form-xml and serializer config for content-view * added excerpt related service defintion file * implemented abstract-excerpt-controller, added messages, queries and exceptions related to excerpt * implemented message-handlers and query-handler related to excerpt * clear images and icons in modify-excerpt-message-handler, fixed class-name in excerpt serializer config, adjusted logic in excerpt-view-factory * fixed target-entity of tags associaltion in excerpt-dimension * added excerpt-dimension-trait, fixed return value of copy-attributes-from method * improved response assertions in abstract-seo-controller-test and abstract-content-controller-test * implemented abstract-excerpt-controller-test, added category-trait, tag-trait and media-trait * added content-view-test and seo-view-test, renamed soe-test to seo-dimension-test * implemented excerpt-dimension-test and excerpt-view-test * implemented excerpt-view-factory-test * added test-cases for messages and queries in excerpt namespace * added test-cases for message-handlers and query-handlers in excerpt namespace * fixed table names for entities in excerpt namespace * removed excerpt-view embeddable
Add date-time payload functions
Add array content serialization for website
* Add "DuplicateContentMessage" * Finish functional test * Fix test * Register service * Fix bug * Use correct method * Fix bug * Add DuplicateExcerptMessage * Add DuplicateSeoMessage * Fix php-cs and phpstan * Add message unit tests * Add message handler unit test * Add tests * Add createClone unit tests * Add createClone unit test * Better unit test * Fix test
* Fix bug in duplicate messages * Fix tests
…erage check (sulu#19) * refactored circleci configuration * exclude vendor folder from coverage report, add coverae-checker script * added lint script in composer.json * added artifacts and test-result configuration * use regex to find path in coverage-checker * automatically fixed coding style with php-cs * add sleep to wait for mysql container * adjusted composer cache config * adjusted test-report paths
Fix exception when data is null
…at-handling bug in payload trait (sulu#22)
…ception Refactor model-not-found exception
* Add Shadow Locale to Settings Tab * Apply suggestions from code review Co-authored-by: Prokyonn <daniel.mathis@sector8.eu> --------- Co-authored-by: Prokyonn <daniel.mathis@sector8.eu>
Co-authored-by: Alexander Schranz <alexander@sulu.io>
* Remove preview condition for shadow entities * Add shadowlocale for preview * Add test for shadow preview * Add review suggestions
* Rename ContentResolver to ContentAggregator * Add upgrade md * Rename content resolver test * Fix upgrade.md * Fix version
* Add own implementation of Controller * Add PropertyResolver and MediaResourceLoader * Add review suggestions * Add unit tests * Add sulu/sulu fork * Keep required sulu version * Update Content/Application/ContentResolver/Value/ContentView.php Co-authored-by: Alexander Schranz <alexander@sulu.io> * Update Content/Application/ResourceLoader/ResourceLoaderInterface.php Co-authored-by: Alexander Schranz <alexander@sulu.io> * Remove sulu fork * Fix tests for php 8.1 * Fix tests for php 8.0 * Enhance content resolver test * Refactor contentResolver and add LinkPropertyProvider * Add tests * Add TeaserSelectionPropertyResolver * Move interfaces and adjust namespaces * Define COMPOSER_TOKEN to fix issues with using forks * Use automation bundle 3.0 * Update Sulu required version * Define composer requirements for Sulu 3.0 * Fix failings tests * Add debug line * Skip resolver tests for now * Trigger CI * Ignore skipped tests --------- Co-authored-by: Alexander Schranz <alexander@sulu.io>
alexander-schranz
changed the title
Feature/content merge into sulu
Add Article Bundle to monorepository
Nov 25, 2024
alexander-schranz
changed the title
Add Article Bundle to monorepository
Add Content Bundle to monorepository
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This will move the content bundle into the Sulu core.
To keep the git history we first moved all files of the content bundle in its own repo into
packages/content
and pushed it here sulu/SuluContentBundle#274.To merge this into the sulu core and keep the git history of content I add my pushed remote to it:
And as
packages/content
never existed in Sulu history I can simple merge the whole history into Sulu core with:Then
git push alex
to my Sulu remote and create the merge request.Why?
Content Bundle will replace our PHPCR storage this will make sure we have it in the Sulu core.
TODO
Will be own merge requests: