Skip to content

Commit

Permalink
feat(components): polish Button components (#605)
Browse files Browse the repository at this point in the history
* feat(components): revert default Button variant to secondary

The previous default Button style matches the new secondary variant most, so to avoid a breaking change, I've made it the default variant.

* feat(components): use IconButton for Carousel buttons

* feat(components): change Hamburger default size to match IconButton

* feat(components): remove Button giga size

To our knowledge, this size was never used. In order to reduce the API surface, we're removing it.

* feat(components): tweak Button border radius

* test(components): update snapshots

* fix(components): fix small icons for Carousel buttons

BREAKING CHANGE:
The Button's `giga` size has been removed. Use the `mega` size (default) instead.
  • Loading branch information
connor-baer authored Jun 4, 2020
1 parent f9cbb24 commit 7769285
Show file tree
Hide file tree
Showing 30 changed files with 1,468 additions and 1,696 deletions.
2 changes: 1 addition & 1 deletion scripts/static-styles/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export default {
}
},
// TODO: Make React DocGen work with TypeScript
// getComponentInfo(Button, { size: [KILO, MEGA, GIGA] }),
// getComponentInfo(Button, { size: [KILO, MEGA] }),
getComponentInfo(Blockquote, {
size: [Blockquote.KILO, Blockquote.MEGA, Blockquote.GIGA]
}),
Expand Down
Loading

0 comments on commit 7769285

Please sign in to comment.