fix: try trick for code coverage

sumup-oss · Mar 21, 2023 · cb2258c · cb2258c
1 parent 43bd6aa
commit cb2258c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/packages/circuit-ui/components/Checkbox/Checkbox.spec.tsx b/packages/circuit-ui/components/Checkbox/Checkbox.spec.tsx
@@ -42,17 +42,21 @@ describe('Checkbox', () => {
     });
 
     it('should render with indeterminate styles', () => {
-      const { container } = render(
+      const { container, getByRole } = render(
         <Checkbox indeterminate {...defaultProps} />,
       );
       expect(container).toMatchSnapshot();
+      const inputEl = getByRole('checkbox') as HTMLInputElement;
+      expect(inputEl.indeterminate).toBeTruthy();
     });
 
     it('should render with indeterminate styles even when checked', () => {
-      const { container } = render(
+      const { container, getByRole } = render(
         <Checkbox checked indeterminate {...defaultProps} />,
       );
       expect(container).toMatchSnapshot();
+      const inputEl = getByRole('checkbox') as HTMLInputElement;
+      expect(inputEl.indeterminate).toBeTruthy();
     });
 
     it('should render with invalid styles and an error message', () => {

diff --git a/packages/circuit-ui/components/Checkbox/Checkbox.tsx b/packages/circuit-ui/components/Checkbox/Checkbox.tsx
@@ -252,13 +252,11 @@ export const Checkbox = forwardRef<HTMLInputElement, CheckboxProps>(
 
     const localRef = useRef<HTMLInputElement>(null);
     useEffect(() => {
-      if (!localRef.current) {
-        return;
+      if (localRef.current) {
+        localRef.current.indeterminate = indeterminate;
       }
-
-      localRef.current.indeterminate = indeterminate;
       // Because it came from a props, we are keeping the `indeterminate` state even if the `checked` one is changed:
-    }, [props.defaultChecked, props.checked, indeterminate]);
+    }, [props.checked, indeterminate]);
 
     return (
       <CheckboxWrapper className={className} style={style} disabled={disabled}>