Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Checkbox and RadioButton components #1875

Closed
connor-baer opened this issue Dec 8, 2022 · 0 comments
Closed

Align Checkbox and RadioButton components #1875

connor-baer opened this issue Dec 8, 2022 · 0 comments
Assignees
Labels
⚛️ component Changes to a React component
Milestone

Comments

@connor-baer
Copy link
Member

connor-baer commented Dec 8, 2022

  • The label for a Checkbox is defined by the Checkbox element's children while the label for a RadioButton is defined by the label prop.

This should be aligned in a future major. All input components should accept a label prop, not children. But out of scope of this one.

Originally posted by @robinmetral in #1815 (comment)

I suppose we could do the same for the RadioButtonGroup right?

Unlike the Checkbox, the RadioButton doesn't wrap its input and label in a wrapper div. I would add a wrapper to the RadioButton component in the next major to align the components.

Originally posted by @connor-baer in #1851 (comment)

@connor-baer connor-baer added the ⚛️ component Changes to a React component label Dec 8, 2022
@connor-baer connor-baer added this to the v7.0 milestone Dec 8, 2022
@github-actions github-actions bot added the stale label May 11, 2023
@sumup-oss sumup-oss deleted a comment from github-actions bot May 11, 2023
@connor-baer connor-baer removed the stale label May 11, 2023
@connor-baer connor-baer self-assigned this May 11, 2023
@connor-baer connor-baer modified the milestones: v7.0, v6.x May 22, 2023
@connor-baer connor-baer modified the milestones: v6.x, v7.0 May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚛️ component Changes to a React component
Projects
None yet
Development

No branches or pull requests

1 participant