Add field wrapper around RadioButtons #2098
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ba74eec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## next #2098 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 258 258
Lines 23148 23145 -3
Branches 2160 2160
=======================================
- Hits 22434 22432 -2
Misses 707 707
+ Partials 7 6 -1
|
robinmetral
approved these changes
May 12, 2023
| options.map((option) => ( | ||
| <RadioButton | ||
| {...option} | ||
| key={option.label} |
There was a problem hiding this comment.
good idea to use the label as the key!
|
Will merge this after merging and rebasing on #2105. |
|
Closing in favor of #2124. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1875.
Purpose
In v6, we wrapped all form fields in a
divto make them easier to style. From the migration guide:We missed doing this for the RadioButton component.
Approach and changes
divfrom the RadioButtonGroupDefinition of done