feat: remove deprecated code #529

connor-baer · 2020-01-21T23:05:28Z

Addresses #469.

Purpose

Remove all components and other code that were deprecated in v1.2 (#470).

Approach and changes

The RestrictedInput has been removed.
The State component has been removed. Use React's useState hook instead.
The RadioButton and Switch components no longer accept the onToggle prop. Use the onChange prop instead.
The Input component no longer accepts *ClassName props. Emotion 10 uses style objects instead of class names. Use the *Styles props instead.
The Heading, SubHeading, Text, and Input components no longer accept the element prop. Emotion 10 introduced the ability to change the HTML element. Use the as prop instead.
The SvgButton component has been renamed to IconButton.
The SideNav component has been removed. Use the Sidebar component instead.
The Picture component has been removed.
The MaskedInput component has been removed. Use react-text-mask directly instead.
The Markdown component has been removed. Use markdown-to-jsx directly instead.
The CreditCardDetails, CardNumberInput, NameOnCardInput, SecurityCodeInput, ExpiryDateInput, and the credit card utils have been removed. Use SumUp's card widget instead.
The ListView component has been renamed to CardList.
The GlobalStyles component has been renamed to BaseStyles. It no longer accepts a custom prop, use Emotion's Global component instead.

Definition of done

codecov · 2020-01-21T23:05:31Z

Codecov Report

Merging #529 into alpha will increase coverage by 13.3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##            alpha     #529      +/-   ##
==========================================
+ Coverage   79.79%   93.09%   +13.3%     
==========================================
  Files         188      154      -34     
  Lines        3256     2462     -794     
  Branches      887      687     -200     
==========================================
- Hits         2598     2292     -306     
+ Misses        542      139     -403     
+ Partials      116       31      -85

Impacted Files	Coverage Δ
.../components/PaymentMethodIcon/PaymentMethodIcon.js	`92.85% <ø> (ø)`	⬆️
src/components/Portal/Portal.js	`5.88% <ø> (-2.69%)`	⬇️
src/components/Input/Input.js	`100% <ø> (ø)`	⬆️
src/components/CardSchemes/card-scheme-icons.js	`100% <ø> (ø)`
src/components/BaseStyles/BaseStyles.js	`100% <100%> (ø)`	⬆️
src/components/SubHeading/SubHeading.js	`100% <100%> (ø)`	⬆️
...ponents/SimpleCurrencyInput/SimpleCurrencyInput.js	`100% <100%> (ø)`	⬆️
src/components/Text/Text.js	`100% <100%> (ø)`	⬆️
src/components/Heading/Heading.js	`100% <100%> (ø)`	⬆️
src/components/BaseStyles/BaseStylesService.js	`100% <100%> (ø)`	⬆️
... and 5 more

vercel · 2020-01-21T23:05:33Z

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/sumup-oss/circuit-ui/88gh7slcv
✅ Preview: https://circuit-ui-git-feature-remove-components.sumup-oss.now.sh

larimaza · 2020-01-27T18:54:47Z

herberthenrique

🔥

herberthenrique · 2020-01-27T19:00:11Z

src/components/CurrencyInput/components/SimpleCurrencyInput/SimpleCurrencyInput.js

hleote

LGTM 👍 💯
Storybook runs fine.
Noticed that we have 38 snapshot tests failing....

Is that normal? Don't you push the new snapshots when stuff is changed?

connor-baer · 2020-01-28T12:57:59Z

@hleote Yes, we always push updates to snapshot files. They’re also checked in CI and since the pipeline ran successfully for this PR, I’m guessing it’s something on your local machine.

Did you update your node modules? Which version of Node are you using?

BREAKING CHANGE: GlobalStyles has been renamed to BaseStyles. It no longer accepts a `custom` prop, use Emotion's Global component instead.

BREAKING CHANGE: ListView has been renamed to CardList.

BREAKING CHANGE: CreditCardDetails, CardNumberInput, NameOnCardInput, SecurityCodeInput, ExpiryDateInput, and the credit card utils have been removed. Use SumUp's card widget instead: https://developer.sumup.com/docs/widgets-card-v2

BREAKING CHANGE: Markdown has been deprecated.

BREAKING CHANGE: MaskedInput has been deprecated. Use react-text-mask directly instead: https://www.npmjs.com/package/react-text-mask

BREAKING CHANGE: Picture has been removed.

BREAKING CHANGE: SideNav has been deprecated. Use the Sidebar component instead.

BREAKING CHANGE: SvgButton has been renamed to IconButton

BREAKING CHANGE: Heading, SubHeading, and Text no longer accept the `element` prop. Emotion 10 introduced the ability to change the HTML element. Use the "as" prop instead.

BREAKING CHANGE: Input component no longer accept `className` props. Emotion 10 uses style objects instead of classnames. Use the "inputStyles" prop instead.

…tch components BREAKING CHANGE: RadioButton and Switch no longer accept the "onToggle" prop. Use the "onChange" prop instead.

BREAKING CHANGE: State has been deprecated. Use React's useState hook instead: https://reactjs.org/docs/hooks-reference.html#usestate

BREAKING CHANGE: RestrictedInput has been removed.

github-actions · 2020-01-28T17:39:41Z

🎉 This PR is included in version 2.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

hleote · 2020-01-28T18:19:23Z

@hleote Yes, we always push updates to snapshot files. They’re also checked in CI and since the pipeline ran successfully for this PR, I’m guessing it’s something on your local machine.

Did you update your node modules? Which version of Node are you using?

Using Node version 12.13.0.
Ok I will check it out it's probably something with my machine in that case 👍 🙂

github-actions · 2020-06-08T08:44:59Z

🎉 This PR is included in version 2.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions · 2020-07-30T16:36:59Z

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

vercel bot deployed to Preview January 22, 2020 00:23 View deployment

connor-baer force-pushed the alpha branch from 32660aa to 9342297 Compare January 22, 2020 00:52

connor-baer force-pushed the feature/remove-components branch from 26cc667 to bf5236e Compare January 22, 2020 00:54

vercel bot deployed to Preview January 22, 2020 00:54 View deployment

connor-baer requested review from afonsodelgado, fernandofleury and hleote January 22, 2020 01:19

connor-baer added this to the v2.0 milestone Jan 22, 2020

connor-baer marked this pull request as ready for review January 22, 2020 01:19

connor-baer added the ready for review label Jan 22, 2020

connor-baer requested review from herberthenrique and removed request for afonsodelgado January 23, 2020 15:00

herberthenrique approved these changes Jan 27, 2020

View reviewed changes

hleote reviewed Jan 28, 2020

View reviewed changes

src/components/CurrencyInput/components/SimpleCurrencyInput/SimpleCurrencyInput.js Show resolved Hide resolved

hleote approved these changes Jan 28, 2020

View reviewed changes

connor-baer added 10 commits January 28, 2020 14:08

feat(components): remove GlobalStyles and custom prop

38d69fc

BREAKING CHANGE: GlobalStyles has been renamed to BaseStyles. It no longer accepts a `custom` prop, use Emotion's Global component instead.

feat(components): remove ListView

e004b53

BREAKING CHANGE: ListView has been renamed to CardList.

feat(components): remove Markdown component

d1860d2

BREAKING CHANGE: Markdown has been deprecated.

feat(components): remove MaskedInput

7ae881e

BREAKING CHANGE: MaskedInput has been deprecated. Use react-text-mask directly instead: https://www.npmjs.com/package/react-text-mask

feat(components): remove Picture

e23cf6c

BREAKING CHANGE: Picture has been removed.

feat(components): remove SideNav and related components

d0525cb

BREAKING CHANGE: SideNav has been deprecated. Use the Sidebar component instead.

feat(components): rename SvgButton to IconButton

8a28904

BREAKING CHANGE: SvgButton has been renamed to IconButton

feat(components): remove element prop on typographic components

c480c7f

BREAKING CHANGE: Heading, SubHeading, and Text no longer accept the `element` prop. Emotion 10 introduced the ability to change the HTML element. Use the "as" prop instead.

feat(components): remove classname props for Input components

0be82f0

BREAKING CHANGE: Input component no longer accept `className` props. Emotion 10 uses style objects instead of classnames. Use the "inputStyles" prop instead.

connor-baer added 3 commits January 28, 2020 14:12

feat(components): rename onToggle to onChange for RadioButton and Swi…

477c2d8

…tch components BREAKING CHANGE: RadioButton and Switch no longer accept the "onToggle" prop. Use the "onChange" prop instead.

feat(components): remove State component

86d9ad3

BREAKING CHANGE: State has been deprecated. Use React's useState hook instead: https://reactjs.org/docs/hooks-reference.html#usestate

feat(components): remove RestrictedInput

57320fd

BREAKING CHANGE: RestrictedInput has been removed.

connor-baer force-pushed the feature/remove-components branch from bf5236e to 57320fd Compare January 28, 2020 17:12

vercel bot deployed to Preview January 28, 2020 17:12 View deployment

connor-baer merged commit e75dc44 into alpha Jan 28, 2020

connor-baer deleted the feature/remove-components branch January 28, 2020 17:34

github-actions bot added the released on @alpha label Jan 28, 2020

github-actions bot added the released on @beta label Jun 8, 2020

github-actions bot added the released label Jul 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: remove deprecated code #529

feat: remove deprecated code #529

connor-baer commented Jan 21, 2020 •

edited

Loading

codecov bot commented Jan 21, 2020 •

edited

Loading

vercel bot commented Jan 21, 2020 •

edited

Loading

larimaza commented Jan 27, 2020

herberthenrique left a comment

herberthenrique commented Jan 27, 2020

hleote left a comment •

edited

Loading

connor-baer commented Jan 28, 2020

github-actions bot commented Jan 28, 2020

hleote commented Jan 28, 2020

github-actions bot commented Jun 8, 2020

github-actions bot commented Jul 30, 2020

feat: remove deprecated code #529

feat: remove deprecated code #529

Conversation

connor-baer commented Jan 21, 2020 • edited Loading

Purpose

Approach and changes

Definition of done

codecov bot commented Jan 21, 2020 • edited Loading

Codecov Report

vercel bot commented Jan 21, 2020 • edited Loading

larimaza commented Jan 27, 2020

herberthenrique left a comment

Choose a reason for hiding this comment

herberthenrique commented Jan 27, 2020

hleote left a comment • edited Loading

Choose a reason for hiding this comment

connor-baer commented Jan 28, 2020

github-actions bot commented Jan 28, 2020

hleote commented Jan 28, 2020

github-actions bot commented Jun 8, 2020

github-actions bot commented Jul 30, 2020

connor-baer commented Jan 21, 2020 •

edited

Loading

codecov bot commented Jan 21, 2020 •

edited

Loading

vercel bot commented Jan 21, 2020 •

edited

Loading

hleote left a comment •

edited

Loading