feat(components): Deprecate components #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## canary #470 +/- ##
==========================================
- Coverage 76.12% 76.09% -0.03%
==========================================
Files 171 167 -4
Lines 2450 2443 -7
Branches 430 433 +3
==========================================
- Hits 1865 1859 -6
Misses 466 466
+ Partials 119 118 -1
|
connor-baer
force-pushed
the
feature/deprecate-components
branch
2 times, most recently
from
c815643
to
0ff1d61
Compare
connor-baer
force-pushed
the
feature/deprecate-components
branch
from
0ff1d61
to
6054503
Compare
ListView is still available but has been deprecated.
connor-baer
force-pushed
the
feature/deprecate-components
branch
from
6054503
to
84b94ee
Compare
marielakas
approved these changes
Sep 18, 2019
mlent
approved these changes
Sep 18, 2019
fernandofleury
suggested changes
Sep 18, 2019
fernandofleury
approved these changes
Sep 18, 2019
|
🎉 This PR is included in version 1.1.1-canary.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
7 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #351 and addresses #469.
Purpose
In preparation for v2 of Circuit UI, we're deprecating a few components to give users a head's up of the upcoming changes.
Approach and changes
HtmlElementcomponent (was only used internally)elementprop on theHeading,SubHeading,Text,ListandInputcomponentsCreditCardDetails,CardNumberInput,NameOnCardInput,SecurityCodeInput, andExpiryDateInputcomponents in favor of the SumUp card widgetMarkdowncomponentMaskedInputcomponentPicturecomponentSideNavcomponentListViewtoCardListGlobalStylestoBaseStylesand deprecate support for custom styles to discourage wrong usageDefinition of done