feat(components): add focus styles to all relevant components #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor-baer
added
🎨 design
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/iu5snb4u4 |
Codecov Report
@@ Coverage Diff @@
## alpha #586 +/- ##
==========================================
+ Coverage 93.50% 93.58% +0.07%
==========================================
Files 153 153
Lines 2448 2477 +29
Branches 685 691 +6
==========================================
+ Hits 2289 2318 +29
Misses 132 132
Partials 27 27
|
feature/focus-outline
feature/focus-outline
feature/focus-outline
feature/focus-outline
feature/focus-outline
feature/focus-outline
This reverts commit e510276.
feature/focus-outline
This is just a wrapper around box-shadow. There's no benefit to turn this in to a helper. BREAKING CHANGE: The `shadowBorder` style helper has been removed. Use the `box-shadow` CSS property instead. feature/focus-outline
feature/focus-outline
feature/focus-outline
Make sort arrows and table rows focusable, add focus styles, and trigger their onClick functions using the keyboard. feature/focus-outline
feature/focus-outline
feature/focus-outline
connor-baer
force-pushed
the
feature/focus-outline
branch
from
8ad0a09
to
ee00c90
Compare
fernandofleury
approved these changes
May 5, 2020
|
🎉 This PR is included in version 2.0.0-alpha.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #410.
Purpose
The goal of this PR is to improve accessibility for users who prefer to navigate using their keyboard or a screen reader. Initially, I focused on the focus styles (pun intended), but there were some other low-hanging fruits that I tackled as well.
I want to thank @larimaza for doing the initial investigation and testing in #410.
Approach and changes
cssprop (they now accept the plain theme or wrapped in an object —themeand{ theme })pointeron hover for Checkbox, RadioButton, Select, Tabs, and Toggle componentsDefinition of done