-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(components): add focus styles to all relevant components #586
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/iu5snb4u4 |
Codecov Report
@@ Coverage Diff @@
## alpha #586 +/- ##
==========================================
+ Coverage 93.50% 93.58% +0.07%
==========================================
Files 153 153
Lines 2448 2477 +29
Branches 685 691 +6
==========================================
+ Hits 2289 2318 +29
Misses 132 132
Partials 27 27
|
feature/focus-outline
feature/focus-outline
feature/focus-outline
feature/focus-outline
feature/focus-outline
feature/focus-outline
This reverts commit e510276.
feature/focus-outline
This is just a wrapper around box-shadow. There's no benefit to turn this in to a helper. BREAKING CHANGE: The `shadowBorder` style helper has been removed. Use the `box-shadow` CSS property instead. feature/focus-outline
feature/focus-outline
feature/focus-outline
Make sort arrows and table rows focusable, add focus styles, and trigger their onClick functions using the keyboard. feature/focus-outline
feature/focus-outline
feature/focus-outline
8ad0a09
to
ee00c90
Compare
🎉 This PR is included in version 2.0.0-alpha.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #410.
Purpose
The goal of this PR is to improve accessibility for users who prefer to navigate using their keyboard or a screen reader. Initially, I focused on the focus styles (pun intended), but there were some other low-hanging fruits that I tackled as well.
I want to thank @larimaza for doing the initial investigation and testing in #410.
Approach and changes
css
prop (they now accept the plain theme or wrapped in an object —theme
and{ theme }
)pointer
on hover for Checkbox, RadioButton, Select, Tabs, and Toggle componentsDefinition of done