feat(components): polish Button components #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous default Button style matches the new secondary variant most, so to avoid a breaking change, I've made it the default variant.
feature/polish-v2
To our knowledge, this size was never used. In order to reduce the API surface, we're removing it. BREAKING CHANGE: The Button's `giga` size has been removed. Use the `mega` size (default) instead.
feature/polish-button
connor-baer
added
feature
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/98mxwx7xz |
feature/polish-button
Codecov Report
@@ Coverage Diff @@
## alpha #605 +/- ##
==========================================
- Coverage 94.26% 94.26% -0.01%
==========================================
Files 136 136
Lines 2198 2196 -2
Branches 631 631
==========================================
- Hits 2072 2070 -2
Misses 103 103
Partials 23 23
|
feature/polish-button
fernandofleury
approved these changes
Jun 4, 2020
|
🎉 This PR is included in version 2.0.0-alpha.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
These changes are an outcome of my conversation with Giao-Chung. The changes reduce the component API surface and make the default styles more consistent.
Approach and changes
secondary: The previous default Button style matches the newsecondaryvariant most, so to avoid a breaking change, I've made it the default variant.gigasize: To our knowledge, this size was never used. In order to reduce the API surface, we're removing it.Definition of done