[Beta] TabList fails to load in create-react-app because it uses component selectors #613
Comments
|
@monken Thank you for the report, this is very useful. I suspect it's because Circuit UI v2 is compiled with TypeScript instead of Babel and the Emotion Babel plugin is no longer applied to the code. We'll fix this in Circuit UI, for the time being, I suggest to add the Babel plugin to your application and see if it works then. |
|
Hi @connor-baer, for any create-react-app application that would mean you'd have to eject which is strongly discouraged. Without rejecting, you cannot modify the babelrc file and add custom plugins. |
|
That's not entirely true, you can use a custom Babel config without ejecting through react-app-rewired. I'm not suggesting this as a permanent solution — we will fix this before the stable v2 release. |
|
awesome, didn't know about that one! |
Since Circuit UI is no longer transpiled with Babel and the Emotion Babel plugin is no longer applied, we can't use component selectors anymore. Closes #613
|
🎉 This issue has been resolved in version 2.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I'm going to close this issue since it has been resolved in the latest beta. @monken, please let us know if you encounter any other issues. |
|
🎉 This issue has been resolved in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Describe the bug
Component selectors require which is not readily available for apps using create-react-app
Steps to reproduce
Steps to reproduce the behavior:
<TabList>component in a create-react-appSpecifications
Additional context
https://github.com/sumup-oss/circuit-ui/blob/beta/src/components/Tabs/components/TabList/TabList.js#L46 seems to be thee culprit.
There might be more instances across the code base where component selectors are used.
The text was updated successfully, but these errors were encountered: