fix(components): replace TabList component selector #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/5ske5ng8c |
Codecov Report
@@ Coverage Diff @@
## beta #616 +/- ##
=======================================
Coverage 93.93% 93.93%
=======================================
Files 133 133
Lines 2145 2145
Branches 624 624
=======================================
Hits 2015 2015
Misses 106 106
Partials 24 24
|
connor-baer
force-pushed
the
bugfix/tab-component-selector
branch
from
3df4375
to
045a9a4
Compare
Since Circuit UI is no longer transpiled with Babel and the Emotion Babel plugin is no longer applied, we can't use component selectors anymore. bugfix/tab-component-selector bugfix/tab-component-selector
fernandofleury
approved these changes
Jun 11, 2020
|
🎉 This PR is included in version 2.0.0-beta.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #613.
Purpose
Since Circuit UI is no longer transpiled with Babel and the Emotion Babel plugin is no longer
applied, we can't use component selectors anymore.
Approach and changes
roleattributeDefinition of done