feat(components): update Badge design #633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the new design specs: https://www.figma.com/file/aORNKPp6e3xbpkYrkfoVhW/WIP-Circuit-UI-Mobile?node-id=2168%3A5419 feature/badge-design
Badges are not meant to be interactive and should only communicate the status of an element. feature/badge-design
It conflicts with the color of the primary Button variant. Use the "neutral" variant instead. feature/badge-design
This makes the prop consistent with the Button and List components BREAKING CHANGE: The **Badge** component's `color` prop has been renamed to `variant` (🤖 _badge-variant-enum_) feature/badge-design
connor-baer
added
feature
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup-oss/circuit-ui/jvny00h7z |
connor-baer
force-pushed
the
feature/badge-design
branch
from
102a5c4
to
0d223cd
Compare
5 tasks
This prevents the content from overflowing the background. feature/badge-design feature/badge-design feature/badge-design
connor-baer
force-pushed
the
feature/badge-design
branch
from
0d223cd
to
febc275
Compare
Codecov Report
@@ Coverage Diff @@
## beta #633 +/- ##
==========================================
+ Coverage 93.67% 93.70% +0.03%
==========================================
Files 133 133
Lines 2197 2208 +11
Branches 606 611 +5
==========================================
+ Hits 2058 2069 +11
Misses 117 117
Partials 22 22
|
hleote
reviewed
Jul 6, 2020
hleote
reviewed
Jul 6, 2020
hleote
approved these changes
Jul 6, 2020
|
🎉 This PR is included in version 2.0.0-beta.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The badges received a design refresh on mobile to make them more accessible and refine their purpose. This PR applies the same changes to the web.
Approach and changes
Before
After
Before
After
onClickprop: Badges are not meant to be interactive and should only communicate the status of an element. Use the Tag component instead.primaryBadge color: It conflicts with the color of the primary Button variant. Use the "neutral" variant instead.colorprop tovariant: This makes the prop consistent with the Button and List components.BREAKING CHANGE:
The Badge component's
colorprop has been renamed tovariant(🤖 badge-variant-enum)Definition of done