Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): update Badge design #633

Merged
merged 5 commits into from
Jul 9, 2020
Merged

feat(components): update Badge design #633

merged 5 commits into from
Jul 9, 2020

Commits on Jul 4, 2020

  1. feat(components): update design of the Badge 

    According to the new design specs:
https://www.figma.com/file/aORNKPp6e3xbpkYrkfoVhW/WIP-Circuit-UI-Mobile?node-id=2168%3A5419

feature/badge-design
    @connor-baer
    connor-baer committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    53cc6fe View commit details
    Browse the repository at this point in the history

  2. feat(components): deprecate Badge's onClick prop 

    Badges are not meant to be interactive and should only communicate the status of an element.

feature/badge-design
    @connor-baer
    connor-baer committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    d265a5d View commit details
    Browse the repository at this point in the history

  3. feat(components): deprecate primary Badge color 

    It conflicts with the color of the primary Button variant. Use the "neutral" variant instead.

feature/badge-design
    @connor-baer
    connor-baer committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    c34a1ae View commit details
    Browse the repository at this point in the history

  4. feat(components): rename Badge's color prop to variant 

    This makes the prop consistent with the Button and List components

BREAKING CHANGE:
The **Badge** component's `color` prop has been renamed to `variant` (🤖 _badge-variant-enum_)

feature/badge-design
    @connor-baer
    connor-baer committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    78402fe View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2020

  1. feat(components): use dynamic width for long circular Badge 

    This prevents the content from overflowing the background.

feature/badge-design

feature/badge-design

feature/badge-design
    @connor-baer
    connor-baer committed Jul 6, 2020
    Configuration menu
    Copy the full SHA
    febc275 View commit details
    Browse the repository at this point in the history