-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Popover API #1013
Improve Popover API #1013
Conversation
Hey @amelako, Thanks! |
🦋 Changeset detectedLatest commit: a3964db The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HW82PbFKt2BXXWFi6nbstiKZUVP9 |
Codecov Report
@@ Coverage Diff @@
## next #1013 +/- ##
==========================================
- Coverage 91.05% 91.03% -0.03%
==========================================
Files 161 161
Lines 2684 2689 +5
Branches 794 798 +4
==========================================
+ Hits 2444 2448 +4
- Misses 214 215 +1
Partials 26 26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how the tests are simpler now ✨
Let's address two more things in this PR:
- Adding transitions for the bottom sheet on mobile
- Adding support for custom Popper
modifiers
Addresses #723.
Purpose
Some improvements for the Popover API and accessibility.
Approach and changes
Remove ref from trigger component in the Popover
Move the isOpen state outside of component
Add aria-expanded prop to trigger component
Add modifiers prop for custom Popper modifier support
Definition of done