Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the thickness of the Hr component #1036

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Conversation

connor-baer
Copy link
Member

Purpose

The Hr (horizontal rule) component should be 1px thick according to the design in Figma. Marcela, a designer on the acquisition journey squad, reported the inconsistency 🙌🏻

Approach and changes

  • Reduce the Hr thickness from 2px to 1px
  • Improve the phrasing of the docs

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2021

🦋 Changeset detected

Latest commit: 3993cc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/9N2bYam76RMv9Qzdq4niBnLwi4q9
✅ Preview: https://oss-circuit-ui-git-feature-hr-thickness-sumup.vercel.app

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1036 (3993cc5) into main (d9ac0f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1036   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         163      163           
  Lines        3016     3016           
  Branches      787      787           
=======================================
  Hits         2775     2775           
  Misses        212      212           
  Partials       29       29           
Impacted Files Coverage Δ
packages/circuit-ui/components/Hr/Hr.tsx 100.00% <ø> (ø)

Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@connor-baer connor-baer merged commit 0a17a44 into main Jul 13, 2021
@connor-baer connor-baer deleted the feature/hr-thickness branch July 13, 2021 12:41
This was referenced Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants