Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and export the inputOutline style mixin #1037

Merged
merged 4 commits into from
Jul 14, 2021
Merged

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Jul 13, 2021

Purpose

This exports the inputOutline externally and documents it properly in Storybook.

Approach and changes

  • export the mixin
  • add documentation in Storybook
  • add missing unit test for the disabled state
  • add changeset

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@sumup-clark
Copy link

sumup-clark bot commented Jul 13, 2021

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Jul 13, 2021

🦋 Changeset detected

Latest commit: 1b69d04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/79zJHbBsi9JvKWgQQfEtY8Yu1f9H
✅ Preview: https://oss-circuit-ui-git-export-inputoutline-sumup.vercel.app

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #1037 (1b69d04) into main (0a17a44) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1037   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         163      163           
  Lines        3016     3016           
  Branches      787      787           
=======================================
  Hits         2775     2775           
  Misses        212      212           
  Partials       29       29           
Impacted Files Coverage Δ
packages/circuit-ui/styles/style-mixins.ts 98.94% <ø> (ø)

.changeset/cold-beds-sort.md Outdated Show resolved Hide resolved
packages/circuit-ui/styles/style-mixins.docs.mdx Outdated Show resolved Hide resolved
packages/circuit-ui/styles/style-mixins.ts Outdated Show resolved Hide resolved
packages/circuit-ui/styles/style-mixins.ts Outdated Show resolved Hide resolved
packages/circuit-ui/styles/style-mixins.ts Outdated Show resolved Hide resolved
@robinmetral robinmetral merged commit 275eef7 into main Jul 14, 2021
@robinmetral robinmetral deleted the export-inputoutline branch July 14, 2021 08:16
@github-actions github-actions bot mentioned this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants