-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only control focus when toggling Popover #1046
Conversation
🦋 Changeset detectedLatest commit: 61d11cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## next #1046 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 164 164
Lines 2780 2782 +2
Branches 813 814 +1
=======================================
+ Hits 2546 2548 +2
Misses 211 211
Partials 23 23
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/2hxcSngknJnN7ncZaQuZXhdqyLqN |
Co-authored-by: Robin Métral <robin.metral@sumup.com>
Purpose
Currently, the Popover immediately hijacks the focus when rendered. It should only control the focus when toggled.
Approach and changes
Definition of done