Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for drag'n'drop and paste to ImageInput #1053

Merged
merged 5 commits into from
Jul 23, 2021

Conversation

connor-baer
Copy link
Member

Purpose

It's a common feature for custom file inputs to support drag'n'drop. Pasting files is less common, but very helpful for keyboard users.

Approach and changes

  • Add support for drag'n'drop to the ImageInput
  • Add support for paste to the ImageInput
  • Handle asynchronous onClear prop on the ImageInput

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2021

🦋 Changeset detected

Latest commit: 9b3da08

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/F5mmT3UBNn7wTpe3WMfDcZxS3TUY
✅ Preview: https://oss-circuit-ui-git-bugfix-imageinput-clear-promise-sumup.vercel.app

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1053 (9b3da08) into main (f202a67) will decrease coverage by 0.23%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1053      +/-   ##
==========================================
- Coverage   92.00%   91.76%   -0.24%     
==========================================
  Files         163      163              
  Lines        3013     3037      +24     
  Branches      782      789       +7     
==========================================
+ Hits         2772     2787      +15     
- Misses        212      221       +9     
  Partials       29       29              
Impacted Files Coverage Δ
...es/circuit-ui/components/ImageInput/ImageInput.tsx 88.29% <75.00%> (-8.53%) ⬇️
packages/circuit-ui/util/test-utils.tsx 100.00% <100.00%> (ø)

Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐉&💧

@connor-baer connor-baer merged commit ad7d6c8 into main Jul 23, 2021
@connor-baer connor-baer deleted the bugfix/imageinput-clear-promise branch July 23, 2021 09:45
@github-actions github-actions bot mentioned this pull request Jul 23, 2021
@github-actions github-actions bot mentioned this pull request Sep 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants