-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for drag'n'drop and paste to ImageInput #1053
Conversation
🦋 Changeset detectedLatest commit: 9b3da08 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/F5mmT3UBNn7wTpe3WMfDcZxS3TUY |
Codecov Report
@@ Coverage Diff @@
## main #1053 +/- ##
==========================================
- Coverage 92.00% 91.76% -0.24%
==========================================
Files 163 163
Lines 3013 3037 +24
Branches 782 789 +7
==========================================
+ Hits 2772 2787 +15
- Misses 212 221 +9
Partials 29 29
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐉&💧
Purpose
It's a common feature for custom file inputs to support drag'n'drop. Pasting files is less common, but very helpful for keyboard users.
Approach and changes
onClear
prop on the ImageInputDefinition of done