Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes on the Popover component #1055

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Fixes on the Popover component #1055

merged 3 commits into from
Jul 26, 2021

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jul 23, 2021

Purpose

Currently, the popover obstructs the content behind it when closed.

Approach and changes

  • Prevent pointer events when the Popover is closed

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Jul 23, 2021

🦋 Changeset detected

Latest commit: d5aef57

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/AtsJrczofHEErZCJyuHdamTZL8c2
✅ Preview: https://oss-circuit-ui-git-popover-fixes-sumup.vercel.app

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #1055 (d5aef57) into next (b4aa2c6) will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1055      +/-   ##
==========================================
+ Coverage   91.57%   91.59%   +0.01%     
==========================================
  Files         164      164              
  Lines        2779     2783       +4     
  Branches      809      812       +3     
==========================================
+ Hits         2545     2549       +4     
  Misses        211      211              
  Partials       23       23              
Impacted Files Coverage Δ
packages/circuit-ui/components/Popover/Popover.tsx 96.20% <91.66%> (+0.20%) ⬆️

@connor-baer connor-baer marked this pull request as ready for review July 26, 2021 14:52
@connor-baer connor-baer requested a review from a team as a code owner July 26, 2021 14:52
@connor-baer connor-baer requested review from amelako and removed request for a team July 26, 2021 14:52
@connor-baer connor-baer merged commit a4a514f into next Jul 26, 2021
@connor-baer connor-baer deleted the popover-fixes branch July 26, 2021 16:21
This was referenced Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants