Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the Modal's min-height #1061

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Removed the Modal's min-height #1061

merged 1 commit into from
Jul 27, 2021

Conversation

robinmetral
Copy link
Contributor

Purpose

The Modal had a hardcoded min-height of 320px. This doesn't work well for modals with little content, closer to dialogs.

Approach and changes

Removed the min-height.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@robinmetral robinmetral requested a review from a team as a code owner July 27, 2021 11:35
@robinmetral robinmetral requested review from connor-baer and removed request for a team July 27, 2021 11:35
@sumup-clark
Copy link

sumup-clark bot commented Jul 27, 2021

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@vercel
Copy link

vercel bot commented Jul 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/88i61YAhByTK9VgKP5ASs11MoJfq
✅ Preview: https://oss-circuit-ui-git-modal-min-height-sumup.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2021

🦋 Changeset detected

Latest commit: 7975981

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #1061 (7975981) into next (911f6fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1061   +/-   ##
=======================================
  Coverage   91.35%   91.35%           
=======================================
  Files         164      164           
  Lines        2810     2810           
  Branches      816      816           
=======================================
  Hits         2567     2567           
  Misses        220      220           
  Partials       23       23           
Impacted Files Coverage Δ
packages/circuit-ui/components/Modal/Modal.tsx 95.00% <ø> (ø)

@robinmetral robinmetral merged commit 37a4950 into next Jul 27, 2021
@robinmetral robinmetral deleted the modal-min-height branch July 27, 2021 12:25
This was referenced Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants