Fix useClickOutside when the target element is removed #1072
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When an element is clicked inside the container element and removed right after the click,
useClickOutside
would trigger because, at the time when the hook checks whether the container contains the clicked element, the element has already been detached from the DOM.Thanks @hris27 for the report and suggested fix! 🙌🏻
Approach and changes
mousedown
event. The callback is still triggered on theclick
event because it can be intercepted, unlike themousedown
event.Definition of done