Update Hamburger design #1082
Merged
Update Hamburger design #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/99At8i5R6K3cvw3UB9D9R7Ef681S |
🦋 Changeset detectedLatest commit: eaf3c80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## next #1082 +/- ##
==========================================
+ Coverage 91.50% 91.54% +0.03%
==========================================
Files 165 165
Lines 2895 2908 +13
Branches 853 855 +2
==========================================
+ Hits 2649 2662 +13
Misses 233 233
Partials 13 13
|
5 tasks
robinmetral
approved these changes
Aug 3, 2021
packages/circuit-ui/components/Button/__snapshots__/Button.spec.tsx.snap
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The new navigation components require an update to the Hamburger design:
Before
After
While working on the changes, I also noticed that the Button's
kilosize is slightly too tall.Approach and changes
kilosize from 34px to 32px to align it with the other components.Definition of done