-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve immersive Modal display on iOS #1087
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/GDBq1okFJGCdG4WjzwLdh312XtHh |
🦋 Changeset detectedLatest commit: 7658274 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## next #1087 +/- ##
=======================================
Coverage 91.54% 91.54%
=======================================
Files 165 165
Lines 2908 2908
Branches 855 855
=======================================
Hits 2662 2662
Misses 233 233
Partials 13 13
|
`, | ||
variant === 'immersive' && | ||
cssString` | ||
top: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robinmetral This did the trick for fullscreen on iOS: by setting both top
and bottom
to 0
, we can use 100%
instead of 100vh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
@robinmetral amazing work! thanks for so quick reaction 🚀 |
Addresses this Slack thread.
Purpose
Reported by @chaserunner:
Reported by @Zayebatsu:
Approach and changes
Note: Best viewed without whitespace changes
Definition of done