Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track events without onClick handler #1184

Merged
merged 2 commits into from
Sep 29, 2021
Merged

Track events without onClick handler #1184

merged 2 commits into from
Sep 29, 2021

Conversation

connor-baer
Copy link
Member

Purpose

Links without a custom onClick aren't tracked by the useClickEvent hook.

Approach and changes

  • Fixed the useClickEvent hook to track events even if no custom onClick handler is defined.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Sep 28, 2021
@connor-baer connor-baer added this to the v4.0 milestone Sep 28, 2021
@connor-baer connor-baer requested a review from a team as a code owner September 28, 2021 08:24
@connor-baer connor-baer requested review from robinmetral and removed request for a team September 28, 2021 08:24
@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2021

🦋 Changeset detected

Latest commit: 930b293

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 28, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/9zveb4SJyiwtz1ZyVHrCUZiXTSvJ
✅ Preview: https://oss-circuit-ui-git-bugfix-click-event-sumup.vercel.app

@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1184 (930b293) into next (edbf19d) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1184      +/-   ##
==========================================
+ Coverage   92.21%   92.30%   +0.08%     
==========================================
  Files         179      179              
  Lines        3316     3314       -2     
  Branches     1001      999       -2     
==========================================
+ Hits         3058     3059       +1     
+ Misses        244      241       -3     
  Partials       14       14              
Impacted Files Coverage Δ
...eNavigation/components/PrimaryLink/PrimaryLink.tsx 96.42% <ø> (+3.32%) ⬆️
...ation/components/SecondaryLinks/SecondaryLinks.tsx 100.00% <ø> (+3.70%) ⬆️
...avigation/components/UtilityLinks/UtilityLinks.tsx 100.00% <ø> (+5.88%) ⬆️
...es/circuit-ui/hooks/useClickEvent/useClickEvent.ts 100.00% <100.00%> (ø)

@connor-baer connor-baer merged commit dfbe2bb into next Sep 29, 2021
@connor-baer connor-baer deleted the bugfix/click-event branch September 29, 2021 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants