-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track events without onClick handler #1184
Conversation
🦋 Changeset detectedLatest commit: 930b293 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/9zveb4SJyiwtz1ZyVHrCUZiXTSvJ |
Codecov Report
@@ Coverage Diff @@
## next #1184 +/- ##
==========================================
+ Coverage 92.21% 92.30% +0.08%
==========================================
Files 179 179
Lines 3316 3314 -2
Branches 1001 999 -2
==========================================
+ Hits 3058 3059 +1
+ Misses 244 241 -3
Partials 14 14
|
Purpose
Links without a custom
onClick
aren't tracked by theuseClickEvent
hook.Approach and changes
useClickEvent
hook to track events even if no customonClick
handler is defined.Definition of done