-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tracking of stateful components #1186
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HCZGchVbo9Dh4kiGNkh61fiGXacF |
🦋 Changeset detectedLatest commit: 8f10bbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## next #1186 +/- ##
==========================================
+ Coverage 92.28% 92.31% +0.02%
==========================================
Files 178 178
Lines 3319 3329 +10
Branches 1006 1011 +5
==========================================
+ Hits 3063 3073 +10
Misses 242 242
Partials 14 14
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚜
Addresses WE-714.
Purpose
Until now, we haven't had a consistent way to track stateful components, specifically events related to a state transition. This PR introduces the convention to append a state enum to the tracking label, separated by a pipe (
|
).Approach and changes
label
as required in TypeScript (d130536)Definition of done