-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CRA template #1213
Remove CRA template #1213
Conversation
Hey @robinmetral, Thanks! |
🦋 Changeset detectedLatest commit: be8765c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HcxcVwaYzr4PUp6XBnBLETVnX5Gn |
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
+ Coverage 91.77% 91.80% +0.02%
==========================================
Files 178 178
Lines 3430 3430
Branches 1074 1074
==========================================
+ Hits 3148 3149 +1
+ Misses 265 264 -1
Partials 17 17
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚮
Let's add a changeset to document the change. |
@connor-baer I added a patch for |
Purpose
We're removing our CRA template. We recommend bootstrapping any new frontend project with Next.js using our CNA template.
Approach and changes
Delete the CRA template and mentions of it in docs.
Definition of done