Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CRA template #1213

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Remove CRA template #1213

merged 2 commits into from
Oct 13, 2021

Conversation

robinmetral
Copy link
Contributor

Purpose

We're removing our CRA template. We recommend bootstrapping any new frontend project with Next.js using our CNA template.

Approach and changes

Delete the CRA template and mentions of it in docs.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@robinmetral robinmetral requested a review from a team as a code owner October 13, 2021 13:54
@sumup-clark
Copy link

sumup-clark bot commented Oct 13, 2021

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2021

🦋 Changeset detected

Latest commit: be8765c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@robinmetral robinmetral requested review from connor-baer and removed request for a team October 13, 2021 13:54
@vercel
Copy link

vercel bot commented Oct 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HcxcVwaYzr4PUp6XBnBLETVnX5Gn
✅ Preview: https://oss-circuit-ui-git-bye-cra-template-sumup.vercel.app

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1213 (be8765c) into main (0724c48) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1213      +/-   ##
==========================================
+ Coverage   91.77%   91.80%   +0.02%     
==========================================
  Files         178      178              
  Lines        3430     3430              
  Branches     1074     1074              
==========================================
+ Hits         3148     3149       +1     
+ Misses        265      264       -1     
  Partials       17       17              
Impacted Files Coverage Δ
...mponents/NotificationBanner/NotificationBanner.tsx 83.60% <0.00%> (+1.63%) ⬆️

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚮

@connor-baer
Copy link
Member

Let's add a changeset to document the change.

@robinmetral
Copy link
Contributor Author

robinmetral commented Oct 13, 2021

Let's add a changeset to document the change.

@connor-baer I added a patch for circuit-ui, thoughts?

@robinmetral robinmetral merged commit a27426a into main Oct 13, 2021
@robinmetral robinmetral deleted the bye-cra-template branch October 13, 2021 15:18
@github-actions github-actions bot mentioned this pull request Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants