Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codemod for LoadingButton → Button #1214

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

connor-baer
Copy link
Member

Relates to #1167.

Purpose

Although this isn't a breaking change (yet), we should make the migration as easy as possible for developers.

Approach and changes

  • Add a codemod to rename LoadingButton to Button. Their APIs are identical.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner October 14, 2021 07:55
@connor-baer connor-baer requested review from robinmetral and removed request for a team October 14, 2021 07:55
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2021

🦋 Changeset detected

Latest commit: b40cef6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/FKgE7vMC6h3JuJhmdvwjB9CyMRwX
✅ Preview: https://oss-circuit-ui-git-feature-loading-button-codemod-sumup.vercel.app

Copy link
Contributor

@amelako amelako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟🐼

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #1214 (b40cef6) into main (65ae3c6) will increase coverage by 0.02%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1214      +/-   ##
==========================================
+ Coverage   91.77%   91.80%   +0.02%     
==========================================
  Files         178      179       +1     
  Lines        3430     3442      +12     
  Branches     1074     1075       +1     
==========================================
+ Hits         3148     3160      +12     
  Misses        265      265              
  Partials       17       17              
Impacted Files Coverage Δ
...ges/circuit-ui/cli/migrate/component-names-v4-1.ts 91.66% <91.66%> (ø)
...mponents/NotificationBanner/NotificationBanner.tsx 83.60% <0.00%> (+1.63%) ⬆️

@connor-baer connor-baer merged commit 994ee8e into main Oct 14, 2021
@connor-baer connor-baer deleted the feature/loading-button-codemod branch October 14, 2021 08:06
@github-actions github-actions bot mentioned this pull request Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants