-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the NotificationToast isVisible issue and increase duration #1357
Conversation
Hey @amelako, Thanks! |
🦋 Changeset detectedLatest commit: 209dc87 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HEJhNoch1S7HxMCLKAWjXPgS1Q6v |
Codecov Report
@@ Coverage Diff @@
## main #1357 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 190 190
Lines 3780 3782 +2
Branches 1175 1209 +34
=======================================
+ Hits 3485 3487 +2
+ Misses 277 276 -1
- Partials 18 19 +1
|
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing to add beyond Connor's comment. Thank you!
…nto toast-a11y-bugfix
Purpose
Based on how fast the average American reads, a good lenght of time to keep the toast message up is 5 seconds plus 1 extra second for every 120 words.
The shortest default that should be used as a best practice is 6 seconds.
Approach and changes
Increased the toast duration to 6 seconds.
Definition of done