Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the NotificationToast isVisible issue and increase duration #1357

Merged
merged 6 commits into from
Jan 12, 2022

Conversation

amelako
Copy link
Contributor

@amelako amelako commented Jan 12, 2022

Purpose

Based on how fast the average American reads, a good lenght of time to keep the toast message up is 5 seconds plus 1 extra second for every 120 words.
The shortest default that should be used as a best practice is 6 seconds.

Approach and changes

Increased the toast duration to 6 seconds.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@amelako amelako requested a review from a team as a code owner January 12, 2022 12:35
@sumup-clark
Copy link

sumup-clark bot commented Jan 12, 2022

Hey @amelako,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2022

🦋 Changeset detected

Latest commit: 209dc87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/HEJhNoch1S7HxMCLKAWjXPgS1Q6v
✅ Preview: https://oss-circuit-ui-git-toast-a11y-bugfix-sumup.vercel.app

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1357 (209dc87) into main (681d43e) will increase coverage by 0.00%.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1357   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         190      190           
  Lines        3780     3782    +2     
  Branches     1175     1209   +34     
=======================================
+ Hits         3485     3487    +2     
+ Misses        277      276    -1     
- Partials       18       19    +1     
Impacted Files Coverage Δ
...components/NotificationToast/NotificationToast.tsx 88.88% <0.00%> (-2.03%) ⬇️
...ircuit-ui/components/ToastContext/ToastContext.tsx 92.30% <66.66%> (+0.20%) ⬆️
...rcuit-ui/components/ToastContext/createUseToast.ts 100.00% <100.00%> (ø)
...es/circuit-ui/components/Pagination/Pagination.tsx 91.42% <0.00%> (ø)
...mponents/NotificationBanner/NotificationBanner.tsx 83.60% <0.00%> (+1.63%) ⬆️

@amelako amelako changed the title Increase the NotificationToast duration Fix the NotificationToast isVisible issue and increase duration Jan 12, 2022
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing to add beyond Connor's comment. Thank you!

@amelako amelako merged commit 5d24f0d into main Jan 12, 2022
@amelako amelako deleted the toast-a11y-bugfix branch January 12, 2022 16:31
@github-actions github-actions bot mentioned this pull request Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants