Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add z-index to Notification Toast ListWrapper #1359

Merged
merged 8 commits into from
Jan 13, 2022
Merged

Conversation

amelako
Copy link
Contributor

@amelako amelako commented Jan 13, 2022

Purpose

The Notification Toast didn't have a z-index value set, which caused stacking issues.

Approach and changes

  • Added a new z-index value for the toast to design-tokens.
  • Add z-index to ToastContext ListWrapper.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@amelako amelako requested a review from a team as a code owner January 13, 2022 15:48
@amelako amelako requested review from connor-baer and removed request for a team January 13, 2022 15:48
@sumup-clark
Copy link

sumup-clark bot commented Jan 13, 2022

Hey @amelako,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

🦋 Changeset detected

Latest commit: 1ef3075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sumup/circuit-ui Major
@sumup/design-tokens Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 13, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/6W6aAik6X5WBRAeh3uWct8UNnn33
✅ Preview: https://oss-circuit-ui-git-fix-toast-stacking-sumup.vercel.app

.changeset/tame-pigs-worry.md Outdated Show resolved Hide resolved
.changeset/smart-yaks-walk.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #1359 (1ef3075) into main (ab62a9e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   92.19%   92.19%           
=======================================
  Files         190      190           
  Lines        3782     3782           
  Branches     1209     1209           
=======================================
  Hits         3487     3487           
  Misses        276      276           
  Partials       19       19           
Impacted Files Coverage Δ
...ircuit-ui/components/ToastContext/ToastContext.tsx 92.30% <ø> (ø)
packages/design-tokens/themes/shared.ts 0.00% <ø> (ø)
packages/design-tokens/utils/theme-prop-type.ts 0.00% <ø> (ø)

Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Co-authored-by: Robin Métral <robin.metral@sumup.com>
@amelako amelako merged commit 5804fd8 into main Jan 13, 2022
@amelako amelako deleted the fix-toast-stacking branch January 13, 2022 18:09
@github-actions github-actions bot mentioned this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants