Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export NotificationInline component #1387

Merged
merged 2 commits into from
Jan 26, 2022
Merged

Conversation

amelako
Copy link
Contributor

@amelako amelako commented Jan 26, 2022

Purpose

We forgot to export the NotificationInline component along in #1332.

Approach and changes

Updated index.tsx file to export the NotificationInline.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@amelako amelako requested a review from a team as a code owner January 26, 2022 12:54
@sumup-clark
Copy link

sumup-clark bot commented Jan 26, 2022

Hey @amelako,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Jan 26, 2022

🦋 Changeset detected

Latest commit: 29d3cd0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 26, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/F2y3AhLSFKoEwxAEKQbqfb4RGLWY
✅ Preview: https://oss-circuit-ui-git-export-notification-inline-sumup.vercel.app

@codecov
Copy link

codecov bot commented Jan 26, 2022

Codecov Report

Merging #1387 (29d3cd0) into main (dca015b) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   92.23%   92.20%   -0.03%     
==========================================
  Files         191      191              
  Lines        3837     3837              
  Branches     1223     1223              
==========================================
- Hits         3539     3538       -1     
- Misses        278      279       +1     
  Partials       20       20              
Impacted Files Coverage Δ
...mponents/NotificationBanner/NotificationBanner.tsx 81.96% <0.00%> (-1.64%) ⬇️

@amelako amelako merged commit 23a7e0a into main Jan 26, 2022
@amelako amelako deleted the export-notification-inline branch January 26, 2022 13:42
@github-actions github-actions bot mentioned this pull request Jan 26, 2022
@robinmetral
Copy link
Contributor

Oops 😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants