-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove modern syntax in NotificationInline #1435
Conversation
🦋 Changeset detectedLatest commit: 0a2537a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/8AfMcoL12ptAFnY5jEKLDkYL3NYy |
Codecov Report
@@ Coverage Diff @@
## main #1435 +/- ##
==========================================
+ Coverage 92.31% 92.33% +0.02%
==========================================
Files 193 193
Lines 3889 3889
Branches 1213 1213
==========================================
+ Hits 3590 3591 +1
+ Misses 280 279 -1
Partials 19 19
|
Purpose
Modern JavaScript syntax isn't transpiled in Circuit UI and can lead to build issues in apps that consume Circuit UI.
Approach and changes
yarn bootstrap
Definition of done