Fix prop types of the InlineMessage component #1450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connor-baer
requested review from
robinmetral
and removed request for
a team
🦋 Changeset detectedLatest commit: 29dbf4f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/EuFWtWC88AYSdQfwbHgU8RSFcN2R |
Codecov Report
@@ Coverage Diff @@
## main #1450 +/- ##
==========================================
+ Coverage 92.21% 92.23% +0.02%
==========================================
Files 195 195
Lines 3993 3992 -1
Branches 1260 1260
==========================================
Hits 3682 3682
+ Misses 292 291 -1
Partials 19 19
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #ticket-number.
Purpose
In #1437, the prop types for the InlineMessage were narrowed accidentally. Previously, the styled component was exported directly, which merged the custom prop types with the default HTML attributes of the element. In order to deprecate the component, it was wrapped in a function component that missed the default HTML attributes. This caused errors when passing
childrento the component.Approach and changes
Definition of done