-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the deprecated shadow style mixins #1510
Conversation
…le mixins. This also migrates a remaining use of shadowDouble in the TabList component to the shadow style mixin.
Hey @robinmetral, Thanks! |
🦋 Changeset detectedLatest commit: 5303124 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/7T9oJ3DqafqSerbQmaZwfTDiz8i7 |
Codecov Report
@@ Coverage Diff @@
## canary #1510 +/- ##
=======================================
Coverage 92.57% 92.58%
=======================================
Files 201 201
Lines 4216 4207 -9
Branches 1353 1353
=======================================
- Hits 3903 3895 -8
+ Misses 293 292 -1
Partials 20 20
|
☝️ resolved the merge conflicts in the migration guide via the GH UI. Wish it supported a clean rebase, but 🤷 |
Purpose
Remove the deprecated
shadowSingle
,shadowDouble
andshadowTriple
style mixins.Approach and changes
shadowSingle
,shadowDouble
andshadowTriple
style mixinsshadow
style mixin.Definition of done