Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the deprecated shadow style mixins #1510

Merged
merged 7 commits into from
Apr 6, 2022

Conversation

robinmetral
Copy link
Contributor

@robinmetral robinmetral commented Apr 6, 2022

Purpose

Remove the deprecated shadowSingle, shadowDouble and shadowTriple style mixins.

Approach and changes

  • Remove the deprecated shadowSingle, shadowDouble and shadowTriple style mixins
  • Migrate a remaining use of shadowDouble in the TabList component to the shadow style mixin.
  • ⚠️ Note: this PR doesn't include a codemod. The change should be verified visually, and we expect the current use of deprecated shadow mixins to be flow.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

…le mixins.

This also migrates a remaining use of shadowDouble in the TabList component to the shadow style mixin.
@sumup-clark
Copy link

sumup-clark bot commented Apr 6, 2022

Hey @robinmetral,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Apr 6, 2022

🦋 Changeset detected

Latest commit: 5303124

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 6, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/7T9oJ3DqafqSerbQmaZwfTDiz8i7
✅ Preview: https://oss-circuit-ui-git-remove-legacy-shadow-mixins.sumup-vercel.app

@robinmetral robinmetral marked this pull request as ready for review April 6, 2022 11:10
@robinmetral robinmetral requested a review from a team as a code owner April 6, 2022 11:10
@robinmetral robinmetral requested review from connor-baer and removed request for a team April 6, 2022 11:10
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #1510 (5303124) into canary (c7dfe6a) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           canary    #1510   +/-   ##
=======================================
  Coverage   92.57%   92.58%           
=======================================
  Files         201      201           
  Lines        4216     4207    -9     
  Branches     1353     1353           
=======================================
- Hits         3903     3895    -8     
+ Misses        293      292    -1     
  Partials       20       20           
Impacted Files Coverage Δ
...t-ui/components/Tabs/components/TabList/TabList.js 100.00% <ø> (ø)
packages/circuit-ui/styles/style-mixins.ts 98.94% <ø> (-0.10%) ⬇️
...mponents/NotificationBanner/NotificationBanner.tsx 83.60% <0.00%> (+1.63%) ⬆️

MIGRATION.md Outdated Show resolved Hide resolved
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
@robinmetral
Copy link
Contributor Author

☝️ resolved the merge conflicts in the migration guide via the GH UI. Wish it supported a clean rebase, but 🤷

@robinmetral robinmetral enabled auto-merge (squash) April 6, 2022 13:33
@robinmetral robinmetral merged commit 908f1e7 into canary Apr 6, 2022
@robinmetral robinmetral deleted the remove-legacy-shadow-mixins branch April 6, 2022 16:24
@connor-baer connor-baer mentioned this pull request May 4, 2022
@connor-baer connor-baer mentioned this pull request May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants