-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated notification components #1518
Conversation
Hey @amelako, Thanks! |
🦋 Changeset detectedLatest commit: 07fe0eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/hoBvX6N1QENLahEasvwqdWyFVzjB |
Codecov Report
@@ Coverage Diff @@
## canary #1518 +/- ##
==========================================
+ Coverage 92.48% 92.50% +0.01%
==========================================
Files 201 197 -4
Lines 4189 4120 -69
Branches 1285 1263 -22
==========================================
- Hits 3874 3811 -63
+ Misses 296 290 -6
Partials 19 19 |
👀 my browser had a weird bug and submitted my approval without my consent 😂 But looks good, and no need for the migration guide entry because it's there already ✨ |
Purpose
In #1437 we deprecated the old Notification components and InlineMessage.
In v5 we are removing deprecated components.
Approach and changes
Notification
,NotificationCard
,NotificationList
andInlineMessage
.Definition of done