Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated notification components #1518

Merged
merged 3 commits into from
Apr 12, 2022

Conversation

amelako
Copy link
Contributor

@amelako amelako commented Apr 8, 2022

Purpose

In #1437 we deprecated the old Notification components and InlineMessage.
In v5 we are removing deprecated components.

Approach and changes

  • Remove Notification, NotificationCard, NotificationList and InlineMessage.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@sumup-clark
Copy link

sumup-clark bot commented Apr 8, 2022

Hey @amelako,
we are super excited that you are contributing! 🎉There's one more thing you need to do. Please accept our Contributor License Agreement. It helps you and us to collaborate on clear terms and focus on what we love most: code.

Thanks!

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2022

🦋 Changeset detected

Latest commit: 07fe0eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Apr 8, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/hoBvX6N1QENLahEasvwqdWyFVzjB
✅ Preview: https://oss-circuit-ui-git-remove-old-notification-components.sumup-vercel.app

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1518 (07fe0eb) into canary (cfcbb76) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           canary    #1518      +/-   ##
==========================================
+ Coverage   92.48%   92.50%   +0.01%     
==========================================
  Files         201      197       -4     
  Lines        4189     4120      -69     
  Branches     1285     1263      -22     
==========================================
- Hits         3874     3811      -63     
+ Misses        296      290       -6     
  Partials       19       19              

@amelako amelako marked this pull request as ready for review April 11, 2022 15:25
@amelako amelako requested a review from a team as a code owner April 11, 2022 15:25
@amelako amelako requested review from connor-baer and removed request for a team April 11, 2022 15:25
@robinmetral
Copy link
Contributor

👀 my browser had a weird bug and submitted my approval without my consent 😂

But looks good, and no need for the migration guide entry because it's there already ✨

@amelako amelako merged commit 2987be2 into canary Apr 12, 2022
@amelako amelako deleted the remove-old-notification-components branch April 12, 2022 09:08
This was referenced May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants