-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ListItem leading and trailing element props #1533
Conversation
🦋 Changeset detectedLatest commit: aa15929 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hey @robinmetral, Thanks! |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/6cfrbXvgYsaPti7Y547dETBamjjk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me 👍
Don't forget to update the stories (I know this is WIP) |
Codecov Report
@@ Coverage Diff @@
## canary #1533 +/- ##
==========================================
- Coverage 92.58% 92.57% -0.01%
==========================================
Files 197 198 +1
Lines 4075 4083 +8
Branches 1238 1236 -2
==========================================
+ Hits 3773 3780 +7
- Misses 283 284 +1
Partials 19 19
|
✅ Verified the changes on Chromatic, stories were renamed but there are no visual changes |
Co-authored-by: Connor Bär <connor-baer@users.noreply.github.com>
Purpose
Rename
ListItem
leading and trailing element props for consistency with Figma and mobile platforms.Approach and changes
prefix
intoleadingComponent
suffix
intotrailingComponent
suffixLabel
intotrailingLabel
suffixDetails
intotrailingDetails
ListItem
Add a codemod for👈 this is too complex to codemod, we'll advise a search-and-replace migration strategyListItemGroup
Definition of done