Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Docusaurus #1585

Merged
merged 2 commits into from
May 24, 2022
Merged

Add support for Docusaurus #1585

merged 2 commits into from
May 24, 2022

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented May 17, 2022

Purpose

Alongside Next.js and create-react-app, Docusaurus is another well-established and popular React framework. I believe we should add out-of-the-box support for it.

Approach and changes

  • Add __docusaurus to the list of root ids in the ModalContext

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented May 17, 2022

🦋 Changeset detected

Latest commit: 241c09a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 17, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
oss-circuit-ui ✅ Ready (Inspect) Visit Preview May 18, 2022 at 1:31PM (UTC)

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #1585 (241c09a) into main (bb9a8a3) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1585      +/-   ##
==========================================
- Coverage   92.76%   92.72%   -0.05%     
==========================================
  Files         194      194              
  Lines        4024     4026       +2     
  Branches     1257     1259       +2     
==========================================
  Hits         3733     3733              
- Misses        272      274       +2     
  Partials       19       19              
Impacted Files Coverage Δ
...ircuit-ui/components/ModalContext/ModalContext.tsx 91.66% <100.00%> (+0.36%) ⬆️
...components/NotificationToast/NotificationToast.tsx 89.36% <0.00%> (-4.26%) ⬇️

@connor-baer connor-baer marked this pull request as ready for review May 18, 2022 13:28
@connor-baer connor-baer requested a review from a team as a code owner May 18, 2022 13:28
@connor-baer connor-baer requested review from amelako and removed request for a team May 18, 2022 13:28
@connor-baer connor-baer merged commit 2a8370e into main May 24, 2022
@connor-baer connor-baer deleted the feature/docusaurus branch May 24, 2022 11:09
@connor-baer connor-baer mentioned this pull request May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants