Improve type for icon prop

[connor-baer]

Purpose

While working on the new https://developer.sumup.com, I found a couple of inconsistencies in Circuit UI. I tried to narrow the type of the icon prop in all components that accept it by specifying the accepted sizes. However, TypeScript throws a fit whenever the size prop doesn't match exactly.

Instead, I changed the default size to any to work around this TypeScript limitation and added a new IconComponentType export to the @sumup/icons package.

Approach and changes

• Changed the IconProps default size type to any
• Automatically set the size prop on the Button's icon prop based on the Button's size prop
• Properly hide icons inside a Button

Definition of done

• Development completed
• Reviewers assigned
• Unit and integration tests
• Meets minimum browser support
• Meets accessibility requirements

[changeset-bot]

🦋 Changeset detected

Latest commit: 6727601

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@sumup/circuit-ui	Major
@sumup/icons	Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
oss-circuit-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 22, 2023 8:30am

[codecov]

Codecov Report

Merging #1615 (6727601) into next (f53e433) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             next    #1615      +/-   ##
==========================================
- Coverage   96.88%   96.87%   -0.01%     
==========================================
  Files         258      258              
  Lines       23186    23188       +2     
  Branches     2160     2164       +4     
==========================================
+ Hits        22463    22464       +1     
  Misses        715      715              
- Partials        8        9       +1     

Impacted Files	Coverage Δ
packages/circuit-ui/components/Button/Button.tsx	90.87% <100.00%> (+0.09%)	⬆️
...es/circuit-ui/components/IconButton/IconButton.tsx	94.31% <100.00%> (ø)
...ckages/circuit-ui/components/ListItem/ListItem.tsx	94.27% <100.00%> (-0.49%)	⬇️
...es/circuit-ui/components/Notification/constants.ts	100.00% <100.00%> (ø)
packages/circuit-ui/components/Popover/Popover.tsx	99.77% <100.00%> (+0.22%)	⬆️
...avigation/components/UtilityLinks/UtilityLinks.tsx	100.00% <100.00%> (ø)