Fix spacing in NotificationInline with an action #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e6ba38f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #1719 +/- ##
==========================================
+ Coverage 91.33% 91.39% +0.05%
==========================================
Files 170 170
Lines 3624 3625 +1
Branches 1200 1244 +44
==========================================
+ Hits 3310 3313 +3
+ Misses 296 293 -3
- Partials 18 19 +1
|
robinmetral
reviewed
Aug 20, 2022
packages/circuit-ui/components/NotificationInline/NotificationInline.tsx
Outdated
Show resolved
Hide resolved
connor-baer
force-pushed
the
bugfix/notification-inline-spacing
branch
from
052cfa3
to
e6ba38f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1710.
Approach and changes
NotificationInlineactionDefinition of done